Add current version print to build scripts#845
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the build scripts for both Windows and macOS to make version handling more user-friendly by making the version parameter optional and adding interactive prompts. The scripts now display the current version from package.json and prompt users to enter a new version if not provided as a command-line argument.
Key Changes:
- Version parameter changed from mandatory to optional in both scripts
- Added functionality to read and display current version from package.json
- Implemented interactive prompts for version input when not provided via command line
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| building/windows/build.ps1 | Made version parameter optional, added logic to read current version from package.json and prompt user for new version |
| building/macos/build.sh | Made version parameter optional, added logic to read current version from package.json and prompt user for new version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@Kwash67 Can you test this on Mac? You don't need to build it fully, just ensure it prints the current version out correctly |
1Blademaster
deleted the
844-display-previous-version-in-build-script
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.